Skip to content

Store unregister shutdown #3604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

andrejbranch
Copy link

What this PR does: Allows prevention of unregistering store gateways from the ring on shutdown. Allows prevention of replicating store gateway shard blocks when leaving the ring.

Which issue(s) this PR fixes:
Fixes #2823

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Will update change log after feedback

@andrejbranch andrejbranch force-pushed the store-unregister-shutdown branch 2 times, most recently from 48b08a6 to 820c703 Compare December 14, 2020 22:31
@andrejbranch andrejbranch force-pushed the store-unregister-shutdown branch from 820c703 to 48b08a6 Compare December 14, 2020 22:35
@andrejbranch andrejbranch force-pushed the store-unregister-shutdown branch 3 times, most recently from 9a7596b to f474e5d Compare December 15, 2020 15:52
@andrejbranch andrejbranch force-pushed the store-unregister-shutdown branch from f474e5d to 09e9778 Compare December 15, 2020 16:01
@pstibrany
Copy link
Contributor

Allows prevention of unregistering store gateways from the ring on shutdown. Allows prevention of replicating store gateway shard blocks when leaving the ring.

Keeping store-gateways in the ring isn't enough. When store-gateway restarts, and starts syncing blocks, it sets itself to JOINING state in the ring. Other store-gateways will notice this change and they will start loading the blocks too. See issue #3570 for discussion.

@pstibrany
Copy link
Contributor

Keeping store-gateways in the ring isn't enough. When store-gateway restarts, and starts syncing blocks, it sets itself to JOINING state in the ring. Other store-gateways will notice this change and they will start loading the blocks too. See issue #3570 for discussion.

Scratch that... it may be enough if only single store-gateway is restarting. I need to rethink this.

@bboreham
Copy link
Contributor

@andrejbranch do you think you will come back to work on this?

@andrejbranch
Copy link
Author

andrejbranch commented Feb 25, 2021

@bboreham happy to but need some direction

@stale
Copy link

stale bot commented Jun 2, 2021

This issue has been automatically marked as stale because it has not had any activity in the past 60 days. It will be closed in 15 days if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Store-gateway blocks resharding during rollout
3 participants