Add chunk flush outcome "Dropped", for short series #2998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the series is below a configured length it gets dropped instead of flushed. Add a separate `outcome` for this case, otherwise it is reported as "NoChunksToFlush". Signed-off-by: Bryan Boreham <[email protected]>
Perhaps we can update existing changelog entry to mention this PR number too? |
I can do it when cherry-picking it for the 1.3.0 release. |
pracucci
added a commit
that referenced
this pull request
Aug 10, 2020
If the series is below a configured length it gets dropped instead of flushed. Add a separate `outcome` for this case, otherwise it is reported as "NoChunksToFlush". Signed-off-by: Bryan Boreham <[email protected]> Co-authored-by: Marco Pracucci <[email protected]>
3 tasks
pracucci
added a commit
that referenced
this pull request
Aug 10, 2020
* Add chunk flush outcome "Dropped", for short series (#2998) If the series is below a configured length it gets dropped instead of flushed. Add a separate `outcome` for this case, otherwise it is reported as "NoChunksToFlush". Signed-off-by: Bryan Boreham <[email protected]> Co-authored-by: Marco Pracucci <[email protected]> * Updated CHANGELOG Signed-off-by: Marco Pracucci <[email protected]> Co-authored-by: Bryan Boreham <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
If the series is below a configured length it gets dropped instead of flushed. Add a separate
outcomefor this case, otherwise it is reported as "NoChunksToFlush".Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]If we can get this into 1.3.0 then I don't think it needs a changelog entry; it is amending #2818 which didn't state any specific
outcomevalues