Upgrade Prometheus to release-2.20 branch #2902
Conversation
Signed-off-by: Ganesh Vernekar <[email protected]>
Signed-off-by: Ganesh Vernekar <[email protected]>
There was a problem hiding this comment.
Thanks @codesome ! I checked the dependencies (see below) and LGTM 🚀
Checked dependencies:
github.com/aws/aws-sdk-gofromv1.31.9tov1.33.5: checked the release notes, no changes for usg.yxqyang.asia/hashicorp/consulfromv1.4.0tov1.5.0: checked the CHANGELOG focusing only on "api" changes, looks like only bug fixing has been doneg.yxqyang.asia/hashicorp/memberlistfromv0.2.0tov0.2.2: checked the code diff (no CHANGELOG available) and changes are minor: mostly exported previously private consts and introduced a way to whitelist/blacklist CIDRsg.yxqyang.asia/prometheus/alertmanagerfromv0.20.0tov0.21.0: checked the CHANGELOG. HipChat has been removed
@codesome please mention in the CHANGELOG (as a [CHANGE]) that HipChat support has been removed from the alertmanager (because removed from the Prometheus upstream too)
Signed-off-by: Marco Pracucci <[email protected]>
Signed-off-by: Ganesh Vernekar <[email protected]>
| replace github.com/Azure/azure-sdk-for-go => github.com/Azure/azure-sdk-for-go v36.2.0+incompatible | ||
|
|
||
| replace github.com/Azure/go-autorest => github.com/Azure/go-autorest v13.3.0+incompatible |
There was a problem hiding this comment.
This is also to be noted. There is a big bump here after the removal of these replace.
There was a problem hiding this comment.
You're right! Could you check the azure changelog for any significative change for us, please? I would focus on azure blob storage only.
There was a problem hiding this comment.
Hm, the changelog is not useful at all https://github.com/Azure/azure-sdk-for-go/blob/master/CHANGELOG.md
There was a problem hiding this comment.
No issues with azure-sdk-for-go, that is something Prometheus imports (for the service discovery) and follow these guidelines to avoid breaking changes.
The blob storage client uses github.com/Azure/go-autorest and the upgrade has only 1 breaking change which is not concerning (By default, the DoRetryForStatusCodes functions will no longer infinitely retry a request when the response returns an HTTP status code of 429 (StatusTooManyRequests). To opt in to the old behavior set autorest.Count429AsRetry to false.)
We should be good in terms of blob storage.
Signed-off-by: Ganesh Vernekar [email protected]
What this PR does:
Upgrades Prometheus to release branch which contains some TSDB fixes
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]