Update seriesFlushReason when flushing, not enqueing. #2802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
pracucci
reviewed
Jun 26, 2020
sandeepsukhani
approved these changes
Jun 27, 2020
Signed-off-by: Peter Štibraný <[email protected]>
|
This change makes the metric less useful. |
bboreham
added a commit
that referenced
this pull request
Jun 29, 2020
This reverts commit d16b681. Make the metric useful again. Signed-off-by: Bryan Boreham <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does: This PR changes
cortex_ingester_flush_reasons. It is renamed tocortex_ingester_series_flush_reasonssince it counts series and not chunks, and it is now updated when flushing, not enqueing. This fixes problem described in issue #2287, when idle series could have been enqueued, but then updated before flushing.Which issue(s) this PR fixes:
Fixes #2287
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]