Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename purger target flag #2777

Merged

Conversation

sandeepsukhani
Copy link
Contributor

@sandeepsukhani sandeepsukhani commented Jun 24, 2020

What this PR does:

  1. Rename purger target flag from data-purger to purger.
  2. Fix a flaky test in purger.

Which issue(s) this PR fixes:
Fixes #2776

Checklist

  • Tests updated
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Signed-off-by: Sandeep Sukhani <[email protected]>
Signed-off-by: Sandeep Sukhani <[email protected]>
Signed-off-by: Sandeep Sukhani <[email protected]>
@pstibrany pstibrany merged commit f520b48 into cortexproject:master Jun 25, 2020
@bboreham
Copy link
Contributor

Please keep PRs to one task at a time, so fixes can be cherry-picked to the release branch.

@bboreham
Copy link
Contributor

bboreham commented Jun 25, 2020

Is "purger" experimental? Please say this in docs, changelog, etc.
Edit: Sorry, I see you did say this in CHANGELOG once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flake in TestPurger_Metrics()
4 participants