Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexperimentalize memberlist #2725

Merged
merged 6 commits into from
Jun 16, 2020
Merged

Unexperimentalize memberlist #2725

merged 6 commits into from
Jun 16, 2020

Conversation

pstibrany
Copy link
Contributor

What this PR does: This PR adds missing flags from documentation, and marks Memberlist as no longer experimental. Note that this PR assumes #2713 and #2724 to be merged first.

Which issue(s) this PR fixes:
Fixes #2638

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Copy link
Contributor

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Could you also update ring/kv/client.go? It mentions that memberlist is experimental too.

@pstibrany
Copy link
Contributor Author

Marking as draft to prevent merging, until #2713 and #2724 are merged.

@pstibrany pstibrany marked this pull request as draft June 16, 2020 08:00
@pull-request-size pull-request-size bot added size/M and removed size/S labels Jun 16, 2020
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
@pstibrany pstibrany marked this pull request as ready for review June 16, 2020 11:53
@pstibrany pstibrany merged commit 34b45d1 into cortexproject:master Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up gossip and remove experimental flag from gossiped ring method in docs and config
2 participants