Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose more TSDB metrics from ingesters when running blocks storage #2583

Conversation

pracucci
Copy link
Contributor

What this PR does:
We're investigating latency spikes in ingesters when running the blocks storage and we've realised we don't expose enough metrics to better understand how the system behaves. In this PR I'm proposing to expose:

  • TSDB metrics
  • Ref cache purge duration

Which issue(s) this PR fixes:
N/A

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@pracucci pracucci requested a review from pstibrany May 12, 2020 06:59
Signed-off-by: Marco Pracucci <[email protected]>
Copy link
Contributor

@pstibrany pstibrany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Signed-off-by: Marco Pracucci <[email protected]>

Co-authored-by: Peter Štibraný <[email protected]>
@pracucci pracucci merged commit 4ee4b55 into cortexproject:master May 12, 2020
@pracucci pracucci deleted the add-more-tsdb-metrics-to-ingesters-blocks-storage branch May 12, 2020 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants