Transition ruler to use Thanos bucket clients #2543
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtlisi
changed the title
jtlisi
force-pushed
the
20200420_migrate_ruler_thanos_objstore
branch
from
2375c26 to
e5de464
Compare
pstibrany
reviewed
Apr 30, 2020
Comment on lines
+6
to
+18
| * Removed `-ruler.storage.azure.download-buffer-size` | ||
| * Removed `-ruler.storage.azure.upload-buffer-size` | ||
| * Added `-ruler.storage.azure.endpoint-suffix` | ||
| * Added `-ruler.storage.azure.max-retries` | ||
| * Changed `-ruler.storage.gcs.bucketname` > `-ruler.storage.gcs.bucket-name` | ||
| * Removed `-ruler.storage.gcs.chunk-buffer-size` | ||
| * Removed `-ruler.storage.gcs.request-timeout` | ||
| * Added `-ruler.storage.gcs.service-account` | ||
| * Changed `-ruler.storage.s3.url` > `-ruler.storage.s3.endpoint`, credentials are no longer url encoded and in-memory is no longer an option | ||
| * Changed `-ruler.storage.s3.buckets` > `-ruler.storage.s3.bucket-name`, multiple buckets can no longer be specified | ||
| * Added `-ruler.storage.s3.secret-access-key` | ||
| * Added `-ruler.storage.s3.access-key-id` | ||
| * Added `-ruler.storage.s3.insecure` |
There was a problem hiding this comment.
Is this compatible with 1.x guarantees? It says that Ruler API is experimental, but Ruler itself is not.
so we will will keep deprecated flags around for 2 minor release
There was a problem hiding this comment.
In order to use object storage with the ruler you need to use the experimental API. Since these configs are directly tied to the experimental API I think they should be safe to change.
pracucci
reviewed
May 7, 2020
pkg/ruler/storage.go
Outdated
| GCS gcp.GCSConfig `yaml:"gcs"` | ||
| S3 aws.S3Config `yaml:"s3"` | ||
| Swift openstack.SwiftConfig `yaml:"swift"` | ||
| S3 s3.Config `yaml:"s3"` |
There was a problem hiding this comment.
Super silly thing. Would you mind keeping the same order as before? Will help to simplify the configuration-file-reference.md diff, to easily spot all the changes in the config.
There was a problem hiding this comment.
Yea, sure thing. I got a bit over eager and decided to make it alphabetical for no reason in particular
3 tasks
Signed-off-by: Jacob Lisi <[email protected]>
Signed-off-by: Jacob Lisi <[email protected]>
Signed-off-by: Jacob Lisi <[email protected]>
Signed-off-by: Jacob Lisi <[email protected]>
Signed-off-by: Jacob Lisi <[email protected]>
Signed-off-by: Jacob Lisi <[email protected]>
Signed-off-by: Jacob Lisi <[email protected]>
Signed-off-by: Jacob Lisi <[email protected]>
Signed-off-by: Jacob Lisi <[email protected]>
Signed-off-by: Jacob Lisi <[email protected]>
Signed-off-by: Jacob Lisi <[email protected]>
Signed-off-by: Jacob Lisi <[email protected]>
Signed-off-by: Jacob Lisi <[email protected]>
Signed-off-by: Jacob Lisi <[email protected]>
Signed-off-by: Jacob Lisi <[email protected]>
Signed-off-by: Jacob Lisi <[email protected]>
jtlisi
force-pushed
the
20200420_migrate_ruler_thanos_objstore
branch
from
e5de464 to
ae75042
Compare
2 tasks
|
Closing for now |
|
I only reopened to see what conflicts exist. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
As a next step for #2262 this PR transitions the ruler to using the Thanos bucket client instead of the chunk object client.
The swift integration tests were removed since the client library Thanos uses no longer supports the Auth protocol of the image we are using for integration tests:
Thanos Upstream Client
Docker Image
Which issue(s) this PR fixes:
Related: #2262
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]