Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

query-frontend: fix trace propagation when downstream_url is specifie… #2539

Merged
merged 2 commits into from
Apr 28, 2020
Merged

query-frontend: fix trace propagation when downstream_url is specifie… #2539

merged 2 commits into from
Apr 28, 2020

Conversation

nextus
Copy link
Contributor

@nextus nextus commented Apr 28, 2020

Fixes #2538

pracucci
pracucci reviewed Apr 28, 2020
View reviewed changes
Copy link
Contributor

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nextus for the PR! Have you had a chance to build Cortex from this PR's branch and test tracing with Thanos to see if it works as expected?

@nextus
Copy link
Contributor Author

nextus commented Apr 28, 2020

Yeah, there is a complete trace with custom cortex binary:
image

@pracucci pracucci marked this pull request as ready for review April 28, 2020 13:47
pracucci
pracucci approved these changes Apr 28, 2020
View reviewed changes
Copy link
Contributor

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nextus for the screenshot! Looks a good proof that works as expected.

pstibrany
pstibrany approved these changes Apr 28, 2020
View reviewed changes
Copy link
Contributor

@pstibrany pstibrany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks.

@pracucci
Update CHANGELOG.md
1349984 
Signed-off-by: Marco Pracucci <[email protected]>
@pracucci pracucci merged commit 55e50b3 into cortexproject:master Apr 28, 2020
@nextus nextus deleted the fix-tracing branch April 29, 2020 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pstibrany pstibrany pstibrany approved these changes

@pracucci pracucci pracucci approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

frontend: no tracing propagation when downstream_url has been specified
3 participants
@nextus @pstibrany @pracucci