Improve the frontend slow query logs. #2520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need rebase on #2521 |
This will help for the log to be more readable, parsable. Signed-off-by: Cyril Tovena <[email protected]>
pracucci
force-pushed
the
improve-log-slow-request
branch
from
78d190f to
ba49762
Compare
pracucci
approved these changes
Apr 24, 2020
pracucci
reviewed
Apr 24, 2020
pkg/querier/frontend/frontend.go
Outdated
| "time_taken", queryResponseTime.String(), | ||
| } | ||
| for k, v := range r.URL.Query() { | ||
| append(logMessage, fmt.Sprintf("qs_%s", k), strings.Join(v, ",")) |
There was a problem hiding this comment.
There's a bug here. logMessage is not updated with the result of append(). I fix it for you.
Signed-off-by: Marco Pracucci <[email protected]>
|
For other reviewers, this is an example log: |
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will help for the log to be more readable, parsable. I've also added the traceID using the context logger.
Signed-off-by: Cyril Tovena [email protected]