Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added cortex_distributor_latest_ingested_sample_timestamp_seconds metric #2371

Merged
merged 6 commits into from
Apr 3, 2020
Merged

Added cortex_distributor_latest_ingested_sample_timestamp_seconds metric #2371

merged 6 commits into from
Apr 3, 2020

Conversation

pstibrany
Copy link
Contributor

@pstibrany pstibrany commented Mar 31, 2020

What this PR does: This PR adds cortex_distributor_latest_seen_sample_timestamp_seconds with latest timestamp of sample sent to Cortex. Useful for tracking how far behind prometheus servers are from Cortex point of view.

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@pstibrany
Copy link
Contributor Author

adding tests now...

@pull-request-size pull-request-size bot added size/L and removed size/S labels Mar 31, 2020
@pstibrany pstibrany changed the title Added cortex_ingester_latest_ingested_sample_timestamp_seconds metric Added cortex_distributor_latest_ingested_sample_timestamp_seconds metric Mar 31, 2020
Copy link
Contributor

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change LGTM (I just left a nit). Just a confirmation: do we want the last seen or the max seen so far?

@pstibrany
Copy link
Contributor Author

The change LGTM (I just left a nit). Just a confirmation: do we want the last seen or the max seen so far?

I think we want last seen, so that we know what Prometheus is sending at the moment.

Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
@pstibrany pstibrany merged commit 2260392 into cortexproject:master Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants