/ready now returns 200, not 204 #2330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Štibraný <[email protected]>
pracucci
approved these changes
Mar 25, 2020
Updated CHANGELOG.md Signed-off-by: Peter Štibraný <[email protected]>
gouthamve
approved these changes
Mar 25, 2020
codesome
pushed a commit
to codesome/cortex
that referenced
this pull request
Mar 31, 2020
* /ready now returns 200, not 204 Signed-off-by: Peter Štibraný <[email protected]> * HTTP service now takes a range of expected status codes. Updated CHANGELOG.md Signed-off-by: Peter Štibraný <[email protected]>
2 tasks
simonswine
pushed a commit
to grafana/e2e
that referenced
this pull request
Jan 13, 2022
* /ready now returns 200, not 204 Signed-off-by: Peter Štibraný <[email protected]> * HTTP service now takes a range of expected status codes. Updated CHANGELOG.md Signed-off-by: Peter Štibraný <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does: This PR changes /ready endpoint to return status code 200 instead of 204. 200 is more common, and in some environments it's difficult to change the check from 200 to 204. In Kubernetes, any code greater than or equal to 200 and less than 400 indicates success.
This PR also fixes(Update: Rebased)TestBackwardCompatibilityWithChunksStorageto start first ingester with old image. This same fix has now been posted as #2329, and I will rebase this PR when #2329 is merged.Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]