Cassandra: Fix TLS host verification #2109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you think implementing and testing the above cases would be sufficient? I am a little bit concerned about the possibility of unknowingly breaking existing setups... |
Refs #2007 Signed-off-by: Joshua Mühlfort <[email protected]>
Signed-off-by: Joshua Mühlfort <[email protected]>
|
I just rebased and squashed the previous commits to fewer ones and removed the draft status from the PR. Please note the updated PR description. I hadn't the time to test all cases but can't think of a way this code could break these untested cases. Would you like to wait for implementation of #2137 or review this PR right away? Are there some other things to consider? |
pracucci
approved these changes
Mar 30, 2020
Signed-off-by: Joshua Mühlfort <[email protected]>
pracucci
approved these changes
Mar 30, 2020
pstibrany
reviewed
Apr 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joshua Mühlfort [email protected]
What this PR does:
Enable TLS host verification for the cassandra storage backend while handling other setups as well.
Which issue(s) this PR fixes:
Fixes #2007
Refs #2013
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]Cases to cover
According to my understanding, the following case will not work with the current gocql API design: