Skip to content
This repository was archived by the owner on Jun 20, 2023. It is now read-only.

Submission flow target screens (EXPOSUREAPP-14240) #5786

Merged
merged 3 commits into from
Jan 3, 2023

Conversation

SamuraiKek
Copy link
Contributor

@SamuraiKek SamuraiKek commented Jan 3, 2023

@SamuraiKek SamuraiKek added bug Something isn't working maintainers Tag pull requests created by maintainers labels Jan 3, 2023
@SamuraiKek SamuraiKek added this to the 3.0.x milestone Jan 3, 2023
@SamuraiKek SamuraiKek requested a review from a team January 3, 2023 12:32
@mtwalli
Copy link
Contributor

mtwalli commented Jan 3, 2023

I got this crash when I register a pending test "for me " and then it became positive

FATAL EXCEPTION: main
                 Process: de.rki.coronawarnapp.test, PID: 20241
                 java.lang.IllegalArgumentException: Navigation action/destination de.rki.coronawarnapp.test:id/action_submissionTestResultPendingFragment_to_submissionTestResultAvailableFragment cannot be found from the current destination Destination(de.rki.coronawarnapp.test:id/submissionTestResultAvailableFragment) label=SubmissionTestResultAvailableFragment class=de.rki.coronawarnapp.ui.submission.resultavailable.SubmissionTestResultAvailableFragment
                 	at androidx.navigation.NavController.navigate(NavController.kt:1540)
                 	at androidx.navigation.NavController.navigate(NavController.kt:1472)
                 	at androidx.navigation.NavController.navigate(NavController.kt:1930)
                 	at de.rki.coronawarnapp.ui.submission.testresult.pending.SubmissionTestResultPendingFragment$onViewCreated$7.invoke(SubmissionTestResultPendingFragment.kt:158)
                 	at de.rki.coronawarnapp.ui.submission.testresult.pending.SubmissionTestResultPendingFragment$onViewCreated$7.invoke(SubmissionTestResultPendingFragment.kt:156)
                 	at de.rki.coronawarnapp.util.ui.LiveDataExtensionsKt$observe2$1.invoke(LiveDataExtensions.kt:10)
                 	at de.rki.coronawarnapp.util.ui.LiveDataExtensionsKt$observe2$1.invoke(LiveDataExtensions.kt:9)
                 	at de.rki.coronawarnapp.util.ui.LiveDataExtensionsKt.observe2$lambda$0(LiveDataExtensions.kt:9)
                 	at de.rki.coronawarnapp.util.ui.LiveDataExtensionsKt.$r8$lambda$7k1b1qbwU-_DraEuRI7WnWYMf8E(Unknown Source:0)
                 	at de.rki.coronawarnapp.util.ui.LiveDataExtensionsKt$$ExternalSyntheticLambda0.onChanged(Unknown Source:2)
                 	at de.rki.coronawarnapp.util.ui.SingleLiveEvent$observe$1.invoke(SingleLiveEvent.kt:55)
                 	at de.rki.coronawarnapp.util.ui.SingleLiveEvent$observe$1.invoke(SingleLiveEvent.kt:53)
                 	at de.rki.coronawarnapp.util.ui.SingleLiveEvent.observe$lambda$0(SingleLiveEvent.kt:53)
                 	at de.rki.coronawarnapp.util.ui.SingleLiveEvent.$r8$lambda$tSmKfiFwr1xyHOraolyvap4e2U0(Unknown Source:0)
                 	at de.rki.coronawarnapp.util.ui.SingleLiveEvent$$ExternalSyntheticLambda0.onChanged(Unknown Source:2)
                 	at androidx.lifecycle.LiveData.considerNotify(LiveData.java:133)
                 	at androidx.lifecycle.LiveData.dispatchingValue(LiveData.java:151)
                 	at androidx.lifecycle.LiveData.setValue(LiveData.java:309)
                 	at androidx.lifecycle.MutableLiveData.setValue(MutableLiveData.java:50)
                 	at de.rki.coronawarnapp.util.ui.SingleLiveEvent.setValue(SingleLiveEvent.kt:63)
                 	at androidx.lifecycle.LiveData$1.run(LiveData.java:93)
                 	at android.os.Handler.handleCallback(Handler.java:900)
                 	at android.os.Handler.dispatchMessage(Handler.java:103)
                 	at android.os.Looper.loop(Looper.java:219)
                 	at android.app.ActivityThread.main(ActivityThread.java:8668)
                 	at java.lang.reflect.Method.invoke(Native Method)
                 	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:513)
                 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1109)

@mtwalli mtwalli self-assigned this Jan 3, 2023
@SamuraiKek
Copy link
Contributor Author

I got this crash when I register a pending test "for me " and then it became positive

FATAL EXCEPTION: main
                 Process: de.rki.coronawarnapp.test, PID: 20241
                 java.lang.IllegalArgumentException: Navigation action/destination de.rki.coronawarnapp.test:id/action_submissionTestResultPendingFragment_to_submissionTestResultAvailableFragment cannot be found from the current destination Destination(de.rki.coronawarnapp.test:id/submissionTestResultAvailableFragment) label=SubmissionTestResultAvailableFragment class=de.rki.coronawarnapp.ui.submission.resultavailable.SubmissionTestResultAvailableFragment
                 	at androidx.navigation.NavController.navigate(NavController.kt:1540)
                 	at androidx.navigation.NavController.navigate(NavController.kt:1472)
                 	at androidx.navigation.NavController.navigate(NavController.kt:1930)
                 	at de.rki.coronawarnapp.ui.submission.testresult.pending.SubmissionTestResultPendingFragment$onViewCreated$7.invoke(SubmissionTestResultPendingFragment.kt:158)
                 	at de.rki.coronawarnapp.ui.submission.testresult.pending.SubmissionTestResultPendingFragment$onViewCreated$7.invoke(SubmissionTestResultPendingFragment.kt:156)
                 	at de.rki.coronawarnapp.util.ui.LiveDataExtensionsKt$observe2$1.invoke(LiveDataExtensions.kt:10)
                 	at de.rki.coronawarnapp.util.ui.LiveDataExtensionsKt$observe2$1.invoke(LiveDataExtensions.kt:9)
                 	at de.rki.coronawarnapp.util.ui.LiveDataExtensionsKt.observe2$lambda$0(LiveDataExtensions.kt:9)
                 	at de.rki.coronawarnapp.util.ui.LiveDataExtensionsKt.$r8$lambda$7k1b1qbwU-_DraEuRI7WnWYMf8E(Unknown Source:0)
                 	at de.rki.coronawarnapp.util.ui.LiveDataExtensionsKt$$ExternalSyntheticLambda0.onChanged(Unknown Source:2)
                 	at de.rki.coronawarnapp.util.ui.SingleLiveEvent$observe$1.invoke(SingleLiveEvent.kt:55)
                 	at de.rki.coronawarnapp.util.ui.SingleLiveEvent$observe$1.invoke(SingleLiveEvent.kt:53)
                 	at de.rki.coronawarnapp.util.ui.SingleLiveEvent.observe$lambda$0(SingleLiveEvent.kt:53)
                 	at de.rki.coronawarnapp.util.ui.SingleLiveEvent.$r8$lambda$tSmKfiFwr1xyHOraolyvap4e2U0(Unknown Source:0)
                 	at de.rki.coronawarnapp.util.ui.SingleLiveEvent$$ExternalSyntheticLambda0.onChanged(Unknown Source:2)
                 	at androidx.lifecycle.LiveData.considerNotify(LiveData.java:133)
                 	at androidx.lifecycle.LiveData.dispatchingValue(LiveData.java:151)
                 	at androidx.lifecycle.LiveData.setValue(LiveData.java:309)
                 	at androidx.lifecycle.MutableLiveData.setValue(MutableLiveData.java:50)
                 	at de.rki.coronawarnapp.util.ui.SingleLiveEvent.setValue(SingleLiveEvent.kt:63)
                 	at androidx.lifecycle.LiveData$1.run(LiveData.java:93)
                 	at android.os.Handler.handleCallback(Handler.java:900)
                 	at android.os.Handler.dispatchMessage(Handler.java:103)
                 	at android.os.Looper.loop(Looper.java:219)
                 	at android.app.ActivityThread.main(ActivityThread.java:8668)
                 	at java.lang.reflect.Method.invoke(Native Method)
                 	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:513)
                 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1109)

This looks like a sepparate bug unrelated to this bugfix and it just wasn't caught yet by the testers. From looking into it, the navigation is called multiple times for the same destination in SubmissionTestResultPendingViewModel on line 79. Can we get this bugfix merged and open another bug ticket with this issue?

@mtwalli
Copy link
Contributor

mtwalli commented Jan 3, 2023

I got this crash when I register a pending test "for me " and then it became positive

FATAL EXCEPTION: main
                 Process: de.rki.coronawarnapp.test, PID: 20241
                 java.lang.IllegalArgumentException: Navigation action/destination de.rki.coronawarnapp.test:id/action_submissionTestResultPendingFragment_to_submissionTestResultAvailableFragment cannot be found from the current destination Destination(de.rki.coronawarnapp.test:id/submissionTestResultAvailableFragment) label=SubmissionTestResultAvailableFragment class=de.rki.coronawarnapp.ui.submission.resultavailable.SubmissionTestResultAvailableFragment
                 	at androidx.navigation.NavController.navigate(NavController.kt:1540)
                 	at androidx.navigation.NavController.navigate(NavController.kt:1472)
                 	at androidx.navigation.NavController.navigate(NavController.kt:1930)
                 	at de.rki.coronawarnapp.ui.submission.testresult.pending.SubmissionTestResultPendingFragment$onViewCreated$7.invoke(SubmissionTestResultPendingFragment.kt:158)
                 	at de.rki.coronawarnapp.ui.submission.testresult.pending.SubmissionTestResultPendingFragment$onViewCreated$7.invoke(SubmissionTestResultPendingFragment.kt:156)
                 	at de.rki.coronawarnapp.util.ui.LiveDataExtensionsKt$observe2$1.invoke(LiveDataExtensions.kt:10)
                 	at de.rki.coronawarnapp.util.ui.LiveDataExtensionsKt$observe2$1.invoke(LiveDataExtensions.kt:9)
                 	at de.rki.coronawarnapp.util.ui.LiveDataExtensionsKt.observe2$lambda$0(LiveDataExtensions.kt:9)
                 	at de.rki.coronawarnapp.util.ui.LiveDataExtensionsKt.$r8$lambda$7k1b1qbwU-_DraEuRI7WnWYMf8E(Unknown Source:0)
                 	at de.rki.coronawarnapp.util.ui.LiveDataExtensionsKt$$ExternalSyntheticLambda0.onChanged(Unknown Source:2)
                 	at de.rki.coronawarnapp.util.ui.SingleLiveEvent$observe$1.invoke(SingleLiveEvent.kt:55)
                 	at de.rki.coronawarnapp.util.ui.SingleLiveEvent$observe$1.invoke(SingleLiveEvent.kt:53)
                 	at de.rki.coronawarnapp.util.ui.SingleLiveEvent.observe$lambda$0(SingleLiveEvent.kt:53)
                 	at de.rki.coronawarnapp.util.ui.SingleLiveEvent.$r8$lambda$tSmKfiFwr1xyHOraolyvap4e2U0(Unknown Source:0)
                 	at de.rki.coronawarnapp.util.ui.SingleLiveEvent$$ExternalSyntheticLambda0.onChanged(Unknown Source:2)
                 	at androidx.lifecycle.LiveData.considerNotify(LiveData.java:133)
                 	at androidx.lifecycle.LiveData.dispatchingValue(LiveData.java:151)
                 	at androidx.lifecycle.LiveData.setValue(LiveData.java:309)
                 	at androidx.lifecycle.MutableLiveData.setValue(MutableLiveData.java:50)
                 	at de.rki.coronawarnapp.util.ui.SingleLiveEvent.setValue(SingleLiveEvent.kt:63)
                 	at androidx.lifecycle.LiveData$1.run(LiveData.java:93)
                 	at android.os.Handler.handleCallback(Handler.java:900)
                 	at android.os.Handler.dispatchMessage(Handler.java:103)
                 	at android.os.Looper.loop(Looper.java:219)
                 	at android.app.ActivityThread.main(ActivityThread.java:8668)
                 	at java.lang.reflect.Method.invoke(Native Method)
                 	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:513)
                 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1109)

This looks like a sepparate bug unrelated to this bugfix and it just wasn't caught yet by the testers. From looking into it, the navigation is called multiple times for the same destination in SubmissionTestResultPendingViewModel on line 79. Can we get this bugfix merged and open another bug ticket with this issue?

I could not reproduce it anymore

@mtwalli mtwalli merged commit d8347f3 into release/3.0.x Jan 3, 2023
@mtwalli mtwalli deleted the fix/14240-submission-flow-target-screens branch January 3, 2023 15:00
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

64.6% 64.6% Coverage
0.0% 0.0% Duplication

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working maintainers Tag pull requests created by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants