Skip to content
This repository was archived by the owner on Jun 20, 2023. It is now read-only.

Checkins navigation crash (EXPOSUREAPP-14361) #5735

Merged
merged 5 commits into from
Nov 30, 2022

Conversation

SamuraiKek
Copy link
Contributor

@SamuraiKek SamuraiKek commented Nov 29, 2022

Navigation to checkins was called twice, causing crash.

@SamuraiKek SamuraiKek added bug Something isn't working maintainers Tag pull requests created by maintainers labels Nov 29, 2022
@SamuraiKek SamuraiKek added this to the 3.0.x milestone Nov 29, 2022
@SamuraiKek SamuraiKek requested a review from a team November 29, 2022 10:39
@schauersbergern
Copy link
Contributor

I've tested it and could reproduce the issue. Unfortunately popping up to checkInOnboardingFragment doesn't solve the issue. I don't think the TraceLocationsFragment should navigate to the CheckinOnboardingFragment. It only does this the first time an event is being created, all other times it will navigate to the FragmentConfirmCheckin where this is not an issue. Just be sure we always navigate to FragmentConfirmCheckin

@schauersbergern schauersbergern self-assigned this Nov 29, 2022
@SamuraiKek
Copy link
Contributor Author

I've tested it and could reproduce the issue. Unfortunately popping up to checkInOnboardingFragment doesn't solve the issue. I don't think the TraceLocationsFragment should navigate to the CheckinOnboardingFragment. It only does this the first time an event is being created, all other times it will navigate to the FragmentConfirmCheckin where this is not an issue. Just be sure we always navigate to FragmentConfirmCheckin

I've found the issue and pushed an actual fix.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@schauersbergern schauersbergern merged commit 6b5c4f7 into release/3.0.x Nov 30, 2022
@schauersbergern schauersbergern deleted the fix/14361-navigation-crash branch November 30, 2022 09:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working maintainers Tag pull requests created by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants