Skip to content
This repository was archived by the owner on Jun 20, 2023. It is now read-only.

Update mixed up strings in statistics info screen (EXPOSUREAPP-14351) #5730

Merged
merged 5 commits into from
Nov 24, 2022
Merged

Update mixed up strings in statistics info screen (EXPOSUREAPP-14351) #5730

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1889c0c
Update mixed up strings.
SamuraiKek Nov 23, 2022
64eb9d5
Merge branch 'release/3.0.x' into fix/14351-mixed-up-text-statistics-…
SamuraiKek Nov 23, 2022
c9250de
Merge branch 'release/3.0.x' into fix/14351-mixed-up-text-statistics-…
schauersbergern Nov 23, 2022
1ea52eb
Update strings with right name.
SamuraiKek Nov 23, 2022
73dd6f9
Merge branch 'release/3.0.x' into fix/14351-mixed-up-text-statistics-…
SamuraiKek Nov 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Corona-Warn-App/src/main/res/values-de/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1498,7 +1498,7 @@ Sollten Sie den Test in der App gelöscht haben, können Sie ihn aus dem Papierk
<!-- XHED: Explanation screen confirmed new infections title -->
<string name="statistics_explanation_confirmed_new_infection_title">"Bestätigte Neuinfektionen"</string>
<!-- XTXT: Explanation screen confirmed new infections text -->
<string name="statistics_explanation_confirmed_new_infection_text" formatted="false">"Anzahl der an das RKI übermittelten Corona-positiv getesteten Personen. Anzahlen unter einem Schwellenwert von 1% des 7-Tage-Mittelwerts werden nicht angezeigt; siehe auch Erläuterung unter Legende > Zeitraum."</string>
<string name="statistics_explanation_confirmed_new_infection_text">"Gesamtzahl der bestätigten Neuinfektionen der letzten 7 Tage (nach Meldedatum) pro 100.000 Einwohner."</string>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably this will now display correctly on the screen because the strings have been exchanged, but the string names do not fit the content.
Here the string name is "statistics_explanation_new_infection_text", and the text is about new infections of the last 7days per 100.000 inhabitants. So this text is related to the 7day incidence and should rather be inserted for "statistics_explanation_seven_day_incidence_text". And it must display under the title "7-Tage Inzidenz" (statistics_explanation_seven_day_incidence_title").
And for "statistics_explanation_new_infection_text", the text should be "Anzahl der an das RKI übermittelten Corona-positiv getesteten Personen. Anzahlen unter einem Schwellenwert..." and needs to be displayed under the title: "Bestätigte Neuinfektionen" (statistics_explanation_confirmed_new_infection_title)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I have reverted the changes to the actual strings and just switched their use in the UI.

<!-- XHED: Explanation screen warned persons title -->
<string name="statistics_explanation_warned_persons_title">"Warnende Personen"</string>
<!-- XTXT: Explanation screen warned persons text -->
Expand All @@ -1508,7 +1508,7 @@ Sollten Sie den Test in der App gelöscht haben, können Sie ihn aus dem Papierk
<!-- XHED: Explanation screen seven day incidence title -->
<string name="statistics_explanation_seven_day_incidence_title">"7-Tage-Inzidenz"</string>
<!-- XTXT: Explanation screen seven day incidence text -->
<string name="statistics_explanation_seven_day_incidence_text">"Anzahl der an das RKI übermittelten Corona-positiv getesteten Personen."</string>
<string name="statistics_explanation_seven_day_incidence_text" formatted="false">"Anzahl der an das RKI übermittelten Corona-positiv getesteten Personen. Anzahlen unter einem Schwellenwert von 1% des 7-Tage-Mittelwerts werden nicht angezeigt; siehe auch Erläuterung unter Legende > Zeitraum."</string>
<!-- XHED: Explanation screen seven day r-value title -->
<string name="statistics_explanation_seven_day_r_value_title">"7-Tage-R-Wert"</string>
<!-- XTXT: Explanation screen seven day r-value text -->
Expand Down