Skip to content
This repository was archived by the owner on Jun 20, 2023. It is now read-only.

Update remaining dialogs (EXPOSUREAPP-14000) #5656

Merged
merged 15 commits into from
Oct 31, 2022

Conversation

SamuraiKek
Copy link
Contributor

This task updates the remaining dialogs in the app to the new dialog fragment approach.

@SamuraiKek SamuraiKek added the maintainers Tag pull requests created by maintainers label Oct 20, 2022
@SamuraiKek SamuraiKek added this to the 2.29.x milestone Oct 20, 2022
@SamuraiKek SamuraiKek requested a review from a team October 20, 2022 11:00
@mtwalli mtwalli self-assigned this Oct 20, 2022
…5663)

* Create a new dialog builder DSL.

* First optimizations to DSL.

* Lint.

* Remove experimental feature.

* Rename builder.

* Improve builder.

* Add StringRes and update doc.

* Add StringRes

* Rename to setCustomView

* Update doc.

* Change example to use string resource.

* Update doc.

* Update doc.
# Conflicts:
#	Corona-Warn-App/src/main/java/de/rki/coronawarnapp/ui/dialog/DialogFragmentTemplateHelper.kt
#	Corona-Warn-App/src/main/java/de/rki/coronawarnapp/ui/onboarding/OnboardingTracingFragment.kt
#	Corona-Warn-App/src/main/java/de/rki/coronawarnapp/ui/submission/warnothers/SubmissionResultPositiveOtherWarningNoConsentFragment.kt
@SamuraiKek SamuraiKek marked this pull request as ready for review October 28, 2022 14:47
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 8 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@mtwalli mtwalli merged commit aa65e26 into release/2.29.x Oct 31, 2022
@mtwalli mtwalli deleted the feature/14000-update-app-dialogs branch October 31, 2022 14:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintainers Tag pull requests created by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants