Fix navigation after test scanning (EXPOSUREAPP-12985)

[SamuraiKek]

Ticket

Scan pending/positive/negative pcr/rat test from the certificates/check-in/journal tabs.
Go through the submission process and you should land on the same tab from where you opened the universal scanner.
For positive tests, canceling the submission process before it's finished will also land you on the tab from where you opened the universal scanner.

The navigation through the submission flow needed to be changed more extensively to match figma and iOS.

When scanning a test (or registaring it through TAN), every operation throughout the submission flow needs to end where the flow was started with the exception of scanning and TAN registering from the dispatcher screen, in which case, the flow should always end on the home fragment.

What to test:

Scan a new PCR/RAT certificate starting from:

1. Status Tab
2. Certificates Tab
3. Check-In tab
4. Journal Tab
5. Manage Your Tests screen

All types of tests must be tested: negative; pending; invalid and positive
For positive tests, canceling the registration, not entering symptoms/warning others and interrupting the flow in general, should always land you on the screen from where the scanning was started.
- also try the os back navigation while registering a positive test
- also try going through the positive test registration with and without giving consent

Try replacing the tests with new ones -> you should go through all/most steps above, especially the positive test registration flow with and without consent.

Try restoring an already deleted test -> again pay attention to positive test registrations, especially ones where the consent was not given and/or others weren't warned.

Try restoring an already deleted test while having a registered test already in the app so that the restored certificate will replace the current one and you have to go through the test deletion screen.

Try registering a test with a TAN.

Try replacing an already registered test by registering a new one with a TAN.

Figma

P.S. I don't know what to do about detekt's LongParameterList error. The params are part of the constructor, can we supress this error somehow?

[github-actions]

Unit Test Results - Device Release

   560 files     560 suites   6m 2s ⏱️
2 779 tests 2 779 ✔️ 0 💤 0 ❌
2 828 runs  2 828 ✔️ 0 💤 0 ❌

Results for commit 3929db6.

♻️ This comment has been updated with latest results.

[github-actions]

Unit Test Results - Device For Tester Release

   563 files     563 suites   6m 4s ⏱️
2 785 tests 2 785 ✔️ 0 💤 0 ❌
2 834 runs  2 834 ✔️ 0 💤 0 ❌

Results for commit 3929db6.

♻️ This comment has been updated with latest results.

[github-actions]

Firebase Test Results

    2 files  +    2      2 suites  +2   4m 35s ⏱️ + 4m 35s
129 tests +129  129 ✔️ +129  0 💤 ±0  0 ❌ ±0 
258 runs  +258  258 ✔️ +258  0 💤 ±0  0 ❌ ±0 

Results for commit 3929db6. ± Comparison against base commit a1cb83c.

♻️ This comment has been updated with latest results.

[SamuraiKek]

While testing for another bug I noticed: When I use the TAN flow and choose No on the symptoms introduction screen I go back to the test result screen, from where sharing fails as it has happened already. Can you check?

Just popping the back stack on the thank you screen is not sufficient. the back stack needs to be cleared when navigating to the thank you screen

I've found the issue and pushed a fix. I've also found a missing dialog which I've added now.

[mtwalli]

Please fix code smells https://sonarcloud.io/project/issues?id=corona-warn-app_cwa-app-android&pullRequest=5408&resolved=false&types=CODE_SMELL

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

7.5% Coverage
0.0% Duplication