Added ability for priors of transformed distributions to have their p… #2551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arameters saved to state_dict
|
This seems like a reasonable workaround to me for the time being, though we should ideally see if saving/loading state dicts can be better supported on the pytorch side. |
dme65
added a commit
that referenced
this pull request
Jul 26, 2024
gpleiss
pushed a commit
that referenced
this pull request
Aug 7, 2024
…rediction strategy (#2559) * Added ability for priors of transformed distributions to have their p… (#2551) (#2552) * avoid unnecessary memory allocation for downdate in SGPR prediction --------- Co-authored-by: David Eriksson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A suggested fix to #2550.
The proposed solution adds a
_transformed_buffer to all of the priors ofTransformedDistributions(LogNormal, HalfNormal, HalfCauchy), as their original parameters cannot be saved tostate_dict. Thus these parameters will be saved and loaded from state_dict, and sets the value of the parameters of the corresponding base distributions.Added some tests for these methods as well, hopefully they are sufficient.