Deprecate last_dim_is_batch (bump PyTorch version to >= 2.0) #2549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NewtonGirardAdditiveKernel This kernel will be deprecated and removed as part of GPyTorch 2.0.
Include instructions for alternative implementation for the following deprecated kernels: - AdditiveStructureKernel - ProductStructureKernel - NewtonGirardAdditiveKernel
- Kernels called with last_dim_is_batch raise a DeprecationWarning - AdditiveStructureKernel, ProductStructureKernel, and NewtonGirardAdditiveKernel raise DeprecationWarnings when instantiated. - Update example notebooks to remove usage of these deprecated kernels.
|
This PR should be ready to merge (into |
JonathanWenger
requested changes
Jul 11, 2024
Co-authored-by: Jonathan Wenger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See conversation here: #2544 (comment)
#2544 will remove
last_dim_is_batchfor GPyTorch 2.0. This PR...AdditiveStructureKernel,ProductStructureKernel, andNewtonGirardAdditiveKernel; the 3 kernels that relied onlast_dim_is_batch.gpytorch.utils.sum_interaction_terms, which replaces the core functionality ofNewtonGirardAdditiveKernel.The last change uses vmaps, so we can use this PR as an excuse to bump the PyTorch requirement to >= 2.0.