Fix lazy kernel slicing when there are multiple outputs #2376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Balandat
approved these changes
Jul 15, 2023
|
@Balandat, thanks for the review! I've simplified the None start/stop filling and added a unittest that covers the behaviour. |
|
Looks like the linter / code formatter is unhappy, other than that this lgtm |
Ah, sorry for that! I've run ufmt on both files I touched and pushed the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug when slicing a lazy kernel and the number of outputs per row or column is greater than one.
The master implementation incorrectly checks to see if x1 and x2 are both slices. This always fails and defaults to the super method.
This PR fixes that check to ensure that row_index and col_index are slices.
The changes on the other lines are necessary to catch situations where the start point or end point of the slicing is implicit.