Skip to content

Accept closure argument in NGD optimizer step #2118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 6, 2022
Merged

Accept closure argument in NGD optimizer step #2118

merged 5 commits into from
Sep 6, 2022

Conversation

dannyfriar
Copy link
Contributor

@dannyfriar dannyfriar commented Sep 6, 2022 •
edited
Loading

Make this consistent with the base optimizer class (this also allows using this optimizer with pytorch lightning)

dannyfriar and others added 2 commits September 6, 2022 09:32
@dannyfriar
Accept closure argument in NGD optimizer step
6f7ee01 
Make this consistent with the base optimizer class
@gpleiss
Update NGD docs.
4337a00
@gpleiss gpleiss enabled auto-merge (squash) September 6, 2022 16:38
@gpleiss gpleiss merged commit c928535 into cornellius-gp:master Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpleiss gpleiss gpleiss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dannyfriar @gpleiss