Skip to content

Fix LMCVariationalStrategy example in docs #2112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 6, 2022
Merged

Fix LMCVariationalStrategy example in docs #2112

merged 1 commit into from
Sep 6, 2022

Conversation

adamjstewart
Copy link
Contributor

The first argument to VariationalStrategy should be the model, in this case self.

The latent_dim argument to LMCVariationalStrategy must be negative.

@gpleiss gpleiss merged commit 554526e into cornellius-gp:master Sep 6, 2022
@gpleiss
Copy link
Member

gpleiss commented Sep 6, 2022

Thanks @adamjstewart !

@adamjstewart adamjstewart deleted the fixes/LMCVariationalStrategy branch September 6, 2022 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpleiss gpleiss gpleiss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamjstewart @gpleiss