-
Notifications
You must be signed in to change notification settings - Fork 563
Add Fantasy Strategy for Variational GPs #1874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
wjmaddox
merged 18 commits into
cornellius-gp:master
from
wjmaddox:variational_fantasization
Jun 3, 2022
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
f7a9dda
drop in basic parts of strategies
wjmaddox 176ab53
Merge branch 'gpytorch_master' into variational_fantasization
wjmaddox 7d018ad
Merge branch 'master' into variational_fantasization
wjmaddox 6c5b694
add fantasization notebook
wjmaddox 0e4ca31
add basic unit tests
wjmaddox dd78889
remove extraneous prints
wjmaddox 45d97dd
fixup unit tests
wjmaddox 906b40b
add fantasy tests in var. examples
wjmaddox 65fc084
attempt to fix documentation
wjmaddox e26a029
update rst
wjmaddox 7394641
Merge branch 'master' into variational_fantasization
wjmaddox cb3cce7
add mean/covar flags
wjmaddox 1787a73
Merge branch 'master' into variational_fantasization
wjmaddox 46ceffb
Merge branch 'master' into variational_fantasization
wjmaddox 1a47887
Merge branch 'master' into variational_fantasization
wjmaddox 704da18
add svgp model updating to toctree
wjmaddox 785688b
Merge branch 'master' into variational_fantasization
wjmaddox 9bc2bc4
update docs
wjmaddox File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can see why it might be convenient to always have
get_fantasy_model
return anExactGP
, regardless of the original model class, but it might be worth considering naming this something else, reservingget_fantasy_model
for the version of OVC that returns a variational GP (in other words make a package-level decision to require thatget_fantasy_model
always returns an instance of the original class).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was a thought I originally had but it requires the unstable direct updates to
m
,S
in order to return its own model class itself rather than the exactGP. Although potentially lower overhead in the future to implement new fantasization strategies.