This repository was archived by the owner on Feb 5, 2020. It is now read-only.
Only one command needs to have backup.db owned by core user #17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The less needed to do during a recovery better and I think leaving the etcd backup readable by core is bad. Arguably you don't even need it in the one case it is used if you are ok with all the recovery files being owned by root instead of core.
Personally I do the recover command as root because I find it less error prone to start the recovery by first running
sudo su -
and running each step as root and dropping sudo all together. The last thing you want is a child process or a piped command to fail because sudo wasn't tacked on.