Skip to content

Switch Jenkins image tracking to registry tag due to Samples Operator… … deprecation #1151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ravanelli
Copy link
Member

Added jenkins-stg-agent-base.yaml to work around limitations in the Staging environment. Also updated documentation to note the unreliability of the Staging registry and instructed users to use their own agent image.

@ravanelli ravanelli changed the title manifest: add jenkins-stg-agent-base.yaml due to staging limitations Switch Jenkins image tracking to registry tag due to Samples Operator… … deprecation May 16, 2025
@ravanelli ravanelli force-pushed the pr/fix_stg branch 2 times, most recently from 2ea2426 to 6af98f5 Compare May 16, 2025 21:31
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haven't fully looked through everything yet, but wanted to put a few comments out there for discussion

@ravanelli ravanelli force-pushed the pr/fix_stg branch 2 times, most recently from 41d0ed5 to 6cb26c3 Compare May 20, 2025 18:59
@ravanelli ravanelli requested review from dustymabe and jlebon May 20, 2025 19:59
@ravanelli ravanelli force-pushed the pr/fix_stg branch 2 times, most recently from 5cfc40b to 54b9c11 Compare May 22, 2025 14:22
Comment on lines 23 to 27
RUN if grep 'dummy' /etc/pki/ca-trust/source/anchors/root-ca.crt; then \
rm /etc/pki/ca-trust/source/anchors/root-ca.crt; \
else \
update-ca-trust; \
fi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you try the EOF ? I know it works in newer podman build, but maybe OpenShift builds it doesn't work yet?

RUN <<EOF
    if
    else
    fi
EOF

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it doesn't seem to work

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grr.. It's such a nice feature!

Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking really good Renata. A few comments. We're really close!

ravanelli added 2 commits May 22, 2025 13:52
… deprecation

Starting with OpenShift 4.13, the Cluster Samples Operator has been
downsized and no longer provides updates for non-S2I images like
Jenkins. The `latest` tracked tag was pointing to an image that hadn't been
updated in over two years. This commit updates the image reference to
follow the specific registry tag directly
(registry.redhat.io/ocp-tools-4/jenkins-rhel9:v4.17.0), ensuring we get
the latest maintained version going forward.

To archive this we need to create our own ImageStreams for both the
Jenkins base image and the Jenkins agent image, replacing the deprecated
Samples Operator content.

Signed-off-by: Renata Ravanelli <[email protected]>
 - Update documentation to reflect changes
 - Add note about how to work with the Fedora
Staging pipecfg.

Signed-off-by: Renata Ravanelli <[email protected]>
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Let's roll this out in staging whenever (I assume you've already pretty much been doing that) and then maybe next week after our FCOS releases go out we can update prod?

@ravanelli
Copy link
Member Author

LGTM

Let's roll this out in staging whenever (I assume you've already pretty much been doing that) and then maybe next week after our FCOS releases go out we can update prod?

Yes, staging is good. I'm on PTO next week. I can work on it the week after it. In this way the won't be in the release week as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants