Skip to content

make postprocess more consistent; drop preset from postprocess #3520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 23, 2025
Merged

make postprocess more consistent; drop preset from postprocess #3520

merged 2 commits into from
May 23, 2025

Conversation

dustymabe
Copy link
Member 

manifests: make postprocess preamble more consistent

We always want set -x so we can see more information if things either
fail during a postprocess or if things in the final image somehow don't
turn out how we inpsect. The logs will help us figure out what is going
on.

manifests: drop preset-all from postprocess

This is done in bootc now as of [1] and we've bumped
the bootc submodule since then so we can drop it here now.

[1] https://gitlab.com/fedora/bootc/base-images/commit/4888be4e199583664fe32264f16ff9e166372c34

@dustymabe
manifests: make postprocess preamble more consistent
c6faa98 
We always want set -x so we can see more information if things either
fail during a postprocess or if things in the final image somehow don't
turn out how we inpsect. The logs will help us figure out what is going
on.
@dustymabe dustymabe mentioned this pull request May 22, 2025
Closed
jlebon
jlebon approved these changes May 22, 2025
View reviewed changes
Copy link
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, makes sense. I actually have a similar patch for fedora-bootc as well pending to debug an unrelated thing.

@jlebon jlebon enabled auto-merge (rebase) May 22, 2025 22:27
@dustymabe dustymabe mentioned this pull request May 22, 2025
Merged
@dustymabe
manifests: drop preset-all from postprocess
5d4aac4 
This is done in bootc now as of [1] and we've bumped
the bootc submodule since then so we can drop it here now.

[1] https://gitlab.com/fedora/bootc/base-images/commit/4888be4e199583664fe32264f16ff9e166372c34
@dustymabe dustymabe force-pushed the dusty-postprocess branch from 48d4b62 to 5d4aac4 Compare May 23, 2025 01:13
@jlebon jlebon merged commit 798bcc2 into coreos:testing-devel May 23, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlebon jlebon jlebon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dustymabe @jlebon