Skip to content

mantle/kola/tests: adapt mpath verification #4113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jcapiitao
Copy link
Member

The test needs to be adapted so it doesn't verify that we're on multipath based on whether the device is /dev/mapper/mpath or not, but instead based on udevadm output.

Copy link

openshift-ci bot commented May 21, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@jcapiitao jcapiitao force-pushed the adapt_mpath_verification branch from 3d6361a to 8a30a63 Compare May 21, 2025 10:11
@jcapiitao jcapiitao marked this pull request as ready for review May 21, 2025 10:53
@jcapiitao jcapiitao force-pushed the adapt_mpath_verification branch 2 times, most recently from 912dfdc to a010061 Compare May 21, 2025 11:47
Copy link

openshift-ci bot commented May 21, 2025

@jcapiitao: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/rhcos a010061 link true /test rhcos

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dustymabe
Copy link
Member

Running the multipath.partition test locally I don't see how this update will work:

[core@qemu0 ~]$ findmnt -nvr /var/lib/containers -o SOURCE
/dev/mapper/mpatha
[core@qemu0 ~]$ udevadm info /dev/mapper/mpatha | cat
P: /devices/virtual/block/dm-0
M: dm-0
R: 0
J: b252:0
U: block
T: disk
D: b 252:0
N: dm-0
L: 50
S: disk/by-uuid/dm-mpath-a4da5870-d6c8-4c02-b420-2f9f14d2bd9f
S: disk/by-label/dm-mpath-containers
S: disk/by-id/dm-name-mpatha
S: disk/by-label/containers
S: disk/by-id/scsi-0xd5f7e2fb9beb72d6
S: disk/by-diskseq/4
S: disk/by-id/wwn-0xxd5f7e2fb9beb72d6
S: disk/by-uuid/a4da5870-d6c8-4c02-b420-2f9f14d2bd9f
S: mapper/mpatha
S: disk/by-id/dm-uuid-mpath-0xd5f7e2fb9beb72d6
Q: 4
E: DEVPATH=/devices/virtual/block/dm-0
E: DEVNAME=/dev/dm-0
E: DEVTYPE=disk
E: DISKSEQ=4
E: MAJOR=252
E: MINOR=0
E: SUBSYSTEM=block
E: USEC_INITIALIZED=9164907
E: DM_UDEV_DISABLE_LIBRARY_FALLBACK_FLAG=1
E: DM_UDEV_PRIMARY_SOURCE_FLAG=1
E: DM_UDEV_RULES_VSN=3
E: DM_NAME=mpatha
E: DM_UUID=mpath-0xd5f7e2fb9beb72d6
E: MPATH_DEVICE_READY=1
E: DM_TYPE=scsi
E: DM_WWN=0xxd5f7e2fb9beb72d6
E: DM_SERIAL=0xd5f7e2fb9beb72d6
E: ID_FS_LABEL=containers
E: ID_FS_LABEL_ENC=containers
E: ID_FS_UUID=a4da5870-d6c8-4c02-b420-2f9f14d2bd9f
E: ID_FS_UUID_ENC=a4da5870-d6c8-4c02-b420-2f9f14d2bd9f
E: ID_FS_SIZE=1006632960
E: ID_FS_LASTBLOCK=262144
E: ID_FS_BLOCKSIZE=4096
E: ID_FS_TYPE=xfs
E: ID_FS_USAGE=filesystem
E: NVME_HOST_IFACE=none
E: DEVLINKS=/dev/disk/by-uuid/dm-mpath-a4da5870-d6c8-4c02-b420-2f9f14d2bd9f /dev/disk/by-label/dm-mpath-containers /dev/disk/by-id/dm-name-mpatha /dev/disk/by-label/containers /dev/disk/by-id/scsi-0xd5f7e2fb9beb72d6 /dev/disk/by-diskseq/4 /dev/disk/by-id/wwn-0xxd5f7e2fb9beb72d6 /dev/disk/by-uuid/a4da5870-d6c8-4c02-b420-2f9f14d2bd9f /dev/mapper/mpatha /dev/disk/by-id/dm-uuid-mpath-0xd5f7e2fb9beb72d6
E: TAGS=:systemd:
E: CURRENT_TAGS=:systemd:

There's no DM_MPATH string in there.

@jcapiitao jcapiitao force-pushed the adapt_mpath_verification branch from a010061 to fcb9912 Compare May 22, 2025 10:17
@jcapiitao jcapiitao marked this pull request as draft May 22, 2025 10:18
The test needs to be adapted so it doesn't verify that we're on
multipath based on whether the device is `/dev/mapper/mpath` or not,
but instead based on udevadm output.
@jcapiitao jcapiitao force-pushed the adapt_mpath_verification branch from fcb9912 to 2af72ea Compare May 22, 2025 14:56
@dustymabe
Copy link
Member

@jlebon in the var lib containers mpath test we have:

ExecStart=/usr/sbin/mpathconf --enable

and then use mpatha throughout that particular test. Should we be specifying userfriendlynames=no there and not using mpatha?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants