-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
chore(service): complete ENVs in heyform service #5869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Conversation
This Commit adds support for the rest of the other env VARs to allow docker compose recognize them when a new instance is setutp so features like email sending via SMTP etc can work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the ENVs as the service will not work after your changes. There may be more problems than the ones I commented. After that, please test your changes thoroughly, otherwise I will have to close this.
- REDIS_HOST=keydb | ||
- REDIS_PORT=6379 | ||
- REDIS_PASSWORD=${SERVICE_PASSWORD_KEYDB} | ||
- SERVICE_FQDN_HEYFORM_8000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The indention is incorrect, please fix it
- REDIS_PASSWORD=${SERVICE_PASSWORD_KEYDB} | ||
- SERVICE_FQDN_HEYFORM_8000 | ||
- APP_HOMEPAGE_URL=${APP_HOMEPAGE_URL} | ||
- SESSION_KEY=${SESSION_KEY} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The session and other keys should be autogenerated by Coolify magic ENVs.
- SESSION_KEY=${SESSION_KEY} | ||
- FORM_ENCRYPTION_KEY=${FORM_ENCRYPTION_KEY} | ||
- MONGO_URI=${MONGO_URI} | ||
- REDIS_HOST=${REDIS_HOST} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the Redis details as it will not work like this.
- APP_HOMEPAGE_URL=${APP_HOMEPAGE_URL} | ||
- SESSION_KEY=${SESSION_KEY} | ||
- FORM_ENCRYPTION_KEY=${FORM_ENCRYPTION_KEY} | ||
- MONGO_URI=${MONGO_URI} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the MONGO_URI
as it will also not work like this
This PR adds support for the rest of the other env VARs to allow docker compose recognize them when a new instance is setutp so features like email sending via SMTP etc can work
Changes