Skip to content

chore(service): complete ENVs in heyform service #5869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: next
Choose a base branch
from

Conversation

theafolayan
Copy link
Contributor

@theafolayan theafolayan commented May 21, 2025

This PR adds support for the rest of the other env VARs to allow docker compose recognize them when a new instance is setutp so features like email sending via SMTP etc can work

Changes

  • Adds all other supported ENV config vars to the heyform.yml. Supported vars are from the Heyform docs

This Commit adds support for the rest of the other env VARs to allow docker compose recognize them when a new instance is setutp so features like email sending via SMTP etc can work
Copy link
Member

@peaklabs-dev peaklabs-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the ENVs as the service will not work after your changes. There may be more problems than the ones I commented. After that, please test your changes thoroughly, otherwise I will have to close this.

- REDIS_HOST=keydb
- REDIS_PORT=6379
- REDIS_PASSWORD=${SERVICE_PASSWORD_KEYDB}
- SERVICE_FQDN_HEYFORM_8000
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indention is incorrect, please fix it

- REDIS_PASSWORD=${SERVICE_PASSWORD_KEYDB}
- SERVICE_FQDN_HEYFORM_8000
- APP_HOMEPAGE_URL=${APP_HOMEPAGE_URL}
- SESSION_KEY=${SESSION_KEY}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The session and other keys should be autogenerated by Coolify magic ENVs.

- SESSION_KEY=${SESSION_KEY}
- FORM_ENCRYPTION_KEY=${FORM_ENCRYPTION_KEY}
- MONGO_URI=${MONGO_URI}
- REDIS_HOST=${REDIS_HOST}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the Redis details as it will not work like this.

- APP_HOMEPAGE_URL=${APP_HOMEPAGE_URL}
- SESSION_KEY=${SESSION_KEY}
- FORM_ENCRYPTION_KEY=${FORM_ENCRYPTION_KEY}
- MONGO_URI=${MONGO_URI}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the MONGO_URI as it will also not work like this

@peaklabs-dev peaklabs-dev added ⚙️ Service Issues requesting or PRs adding/fixing service templates. 💤 Waiting for changes PRs awaiting changes from the author. labels May 23, 2025
@peaklabs-dev peaklabs-dev changed the title compete env vars in heyform.yaml chore(service): complete ENVs in heyform service May 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙️ Service Issues requesting or PRs adding/fixing service templates. 💤 Waiting for changes PRs awaiting changes from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants