Fix IPv6 docker issue #965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuva29
force-pushed
the
fix_docker_ipv6_issue
branch
3 times, most recently
from
20de749 to
8c9ebcf
Compare
rchirakk
reviewed
Sep 7, 2017
drivers/ovsd/ovsdbDriver.go
Outdated
| ofpPort := uint32(reflect.ValueOf(value).Float()) | ||
| return ofpPort, nil | ||
| if reflect.ValueOf(value).Float() != -1 { | ||
| ofpPort := uint32(reflect.ValueOf(value).Float()) |
There was a problem hiding this comment.
can't we simplify like this ?
if ofport:= xxxfunc(); ofport != -1 {
return uint32(ofport), nil
}
8c9ebcf to
6750d44
Compare
yuva29
force-pushed
the
fix_docker_ipv6_issue
branch
2 times, most recently
from
447e62b to
42969e6
Compare
Note: Docker containers were not getting IPv6 assigned because
netplugin was not giving it earlier
Signed-off-by: Yuva Shankar <[email protected]>
yuva29
force-pushed
the
fix_docker_ipv6_issue
branch
from
42969e6 to
d111222
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branching #950 PR into 2
Docker containers were not getting IPv6 assigned due to a missing field in the response. So, this enables IPv6 on docker when the underlying network supports IPv6.
Signed-off-by: Yuva Shankar [email protected]