Vagrantfile,.gitignore: Maintain state between vagrant runs. #607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dseevr
approved these changes
Nov 4, 2016
| STATEFILE = ".vagrant-state" | ||
|
|
||
| if File.exist?(STATEFILE) | ||
| File.open(STATEFILE).read.lines.map { |x| x.split("=", 2) }.each { |x,y| ENV[x] = y } |
There was a problem hiding this comment.
File.open("foo").read can be written as File.read("foo") as of 1.9
|
|
||
| def self.up_hook(arg) | ||
| unless File.exist?(STATEFILE) # prevent it from writing more than once. | ||
| f = File.open(STATEFILE, "w") |
There was a problem hiding this comment.
There's also File.write now, so you could do something like:
data = ENV.map { |x,y| "%s=%s" % [x,y] }.join("\n")
File.write(STATEFILE, data)
|
@gaurav-dalvi tested this and @dseevr reviewed. I think this is ready for merge. |
|
LGTM. Thanks @erikh for taking care of this so quickly |
|
Once the tests pass, we can merge. |
|
@erikh needs a bumparoo |
Signed-off-by: Erik Hollensbe <[email protected]>
|
ready for merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch implements a state tracker for vagrant runs. It does this by saving your current environment to a file called
.vagrant-statein the CWD. It then restores that state (if it exists) for each run, allowing you to do any vagrant command without worrying about supplying environment variables to control it. On destroy, the file is removed.This is sufficiently advanced ruby, so please do focus on the functionality. Perhaps @dseevr would like to review this one as I know he's more than capable of doing so.