Fixing Netplugin disconnect #596
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jojimt
reviewed
Nov 2, 2016
| } | ||
| default: | ||
| // return false, "" | ||
| row, err := d.ovs.Transact(ovsDataBase, selectOp) |
There was a problem hiding this comment.
Should we keep the cache look up and fallback to Transact only if there is a miss?
There was a problem hiding this comment.
I believe the issue was with cache not being updated. So it wasnt a miss that was causing the issue. The cache had the vtep but not the ovsdb.
ppadala
approved these changes
Nov 3, 2016
| row, err := d.ovs.Transact(ovsDataBase, selectOp) | ||
|
|
||
| if err == nil && len(row) > 0 && len(row[0].Rows) > 0 { | ||
| value := row[0].Rows[0]["ofport"] |
There was a problem hiding this comment.
what happens if Rows[0] doesn't have ofport key?
|
@abhinandanpb as discussed, let's change only the retry for now. |
abhi
force-pushed
the
triggertestfix
branch
3 times, most recently
from
7480f15 to
13c100c
Compare
|
ping @jojimt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NetpluginDisconnect trigger exposed issue with vxlan vrep creation with ofport not found error.
First suspicion was ovsdb operation being async would need more retries. Also cherry picked sukhesh's commit in this area.