Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile,drivers: Switch to using gofmt -s and correct areas where it does not pass #591

Merged
merged 1 commit into from
Nov 3, 2016

Conversation

erikh
Copy link
Contributor

@erikh erikh commented Oct 28, 2016

No description provided.

@erikh
Copy link
Contributor Author

erikh commented Oct 28, 2016

same @abhinandanpb

@erikh
Copy link
Contributor Author

erikh commented Oct 28, 2016

nvm, more gofmt issues. I'll fix now.

@dseevr
Copy link
Contributor

dseevr commented Oct 31, 2016

There's a few remaining in utils/driverfactory.go

@erikh
Copy link
Contributor Author

erikh commented Nov 1, 2016

this should probably be merged before anything else; reason being is that if someone merges in code this gofmt command will break on, it will break master.

(the rest of my patches are not critical)

@abhi
Copy link
Member

abhi commented Nov 1, 2016

LGTM.

@abhi abhi merged commit 5e2cc57 into contiv:master Nov 3, 2016
@erikh erikh deleted the gofmt branch November 10, 2016 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants