Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix network still has endpoint bug #381

Merged
merged 7 commits into from
May 22, 2016
Merged

Fix network still has endpoint bug #381

merged 7 commits into from
May 22, 2016
+304 −2,799

Conversation

shaleman
Copy link
Contributor

This fixes #366

  • Decouple endpoint count and allocated address count
  • Change the way we send address pool ID in docker IPAM plugin
  • Return gateway address if lib network gateway label is present
  • Add a system test case for network add/delete without gateway
  • Cleanup some unused code

@shaleman
Copy link
Contributor Author

I'm going to merge this to get a release out

@shaleman shaleman merged commit 6e0debf into contiv:master May 22, 2016
abhi pushed a commit to abhi/netplugin that referenced this pull request Jul 12, 2016
@shaleman @abhi
Fix network still has endpoint bug (contiv#381)
42a8838 
* add validators; cleanup code

* dont create endpoint for gateway

* add tests; godep update

* seperate epCount and epAddrCount

* fix merge conflict

* fix merge conflict

* workaround a docker bug
apoorva11029 pushed a commit to apoorva11029/netplugin that referenced this pull request Aug 9, 2016
@shaleman @apoorva11029
Fix network still has endpoint bug (contiv#381)
b286cd5 
* add validators; cleanup code

* dont create endpoint for gateway

* add tests; godep update

* seperate epCount and epAddrCount

* fix merge conflict

* fix merge conflict

* workaround a docker bug
apoorva11029 pushed a commit to apoorva11029/netplugin that referenced this pull request Aug 9, 2016
@shaleman @apoorva11029
Fix network still has endpoint bug (contiv#381)
b50f8b8 
* add validators; cleanup code

* dont create endpoint for gateway

* add tests; godep update

* seperate epCount and epAddrCount

* fix merge conflict

* fix merge conflict

* workaround a docker bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

network delete fails due to "Network has active endpoints"
1 participant
@shaleman