Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for patchlevels when running scripts/checks #29

Closed
wants to merge 1 commit into from
Closed

Check for patchlevels when running scripts/checks #29

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/checks
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
echo "Checking Go version..."
ver=$(go version | awk '{print $3}')
expVer="go1.4"
if [[ ${ver} != ${expVer} ]]; then
if ! echo "$ver" | grep -qE "^$expVer"; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now there is a tight coupling of go-version between host and vagrant environment (where we run unit-tests and it has go1.4) due to go-objects being incompatible between different versions of go. As a result we kept this check strict.

A detailed description of the dependency can be found in this PR as well #17 . It's a trade off we made between keeping test running time low and go-development environment at that moment.

echo "Go version check failed. Expected ${expVer} but found ${ver}"
exit 1
fi
Expand Down