Added GOPATH var in Makefile

[karamsivia]

Changed /opt/gopath to $(GOPATH) in Makefile

[shaleman]

@karamsivia Thanks for submitting the patch.

Some of the changes here will pick up the $GOPATH variable from outside the vagrant VMs and try to access the directory inside the vagrant VMs. Jenkins sanity failed for the same reason.
Can you please keep only this change and remove the other changes in your patch?

run-build: deps checks clean
    cd ${GOPATH}/src/github.com/contiv/netplugin && version/generate_version ${USE_RELEASE} && \
 -  cd /opt/gopath/src/github.com/contiv/netplugin && \
 +  cd $(GOPATH)/src/github.com/contiv/netplugin && \
    godep go install -v $(TO_BUILD) && \
    sudo cp contrib/completion/bash/netctl /etc/bash_completion.d/netctl

[karamsivia]

Sukhesh,

I made the change to my repo. Do I need to submit another pull request?

-Karam

On Wed, Feb 17, 2016 at 12:40 PM, Sukhesh Halemane <[email protected]

wrote:

@karamsivia https://github.com/karamsivia Thanks for submitting the
patch.

Some of the changes here will pick up the $GOPATH variable from outside
the vagrant VMs and try to access the directory inside the vagrant VMs.
Jenkins sanity failed for the same reason.
Can you please keep only this change and remove the other changes in your
patch?

run-build: deps checks clean
cd ${GOPATH}/src/github.com/contiv/netplugin && version/generate_version ${USE_RELEASE} && \

• cd /opt/gopath/src/github.com/contiv/netplugin && \
• cd $(GOPATH)/src/github.com/contiv/netplugin &&
  godep go install -v $(TO_BUILD) &&
  sudo cp contrib/completion/bash/netctl /etc/bash_completion.d/netctl

—
Reply to this email directly or view it on GitHub
#288 (comment).

[shaleman]

Thanks @karamsivia.
Update is already pushed to the PR and sanity is running.
I'll merge it once sanity passes..