Fix https://github.com/contiv/netplugin/issues/256 #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rework the fix to read current state and watch the next index Use EtcdIndex for watching
jojimt
force-pushed
the
I256-vtep
branch
2 times, most recently
from
a783b31 to
41650e6
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When multiple nodes start up almost at the same time, it is possible for the netplugin to miss some peer registrations in the real-time window between a service state read and the watch which occurs in a different thread. This fix forces the WatchService routine to inject the current state of the service to the listening channel and utilizes that for the initial state sync, instead of separately reading the state.