centralize resource allocation #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| github.com/contiv/netplugin/gstate" | ||
| github.com/contiv/netplugin/gstate \ | ||
| github.com/contiv/netplugin/netmaster \ | ||
| " |
There was a problem hiding this comment.
Can you add some system-tests with this commit? I think we need system-tests around Config Deletes and Vxlan stuff.
There was a problem hiding this comment.
Makes sense. Let me add at least following: config delta (desired state based), config add, config delete, and vxlan related ones
|
@jainvipin, the comments came out in the reverse order ... I think it take the order in which 'comment' is pressed and not by order of files...it might be easier to go through comments bottom up. Sorry for the inconvenience 😞 |
dseevr
pushed a commit
to dseevr-dev/netplugin
that referenced
this pull request
Oct 25, 2017
etcdClient.go: fixed a bug where nil was returned instead of err
dseevr
pushed a commit
to dseevr-dev/netplugin
that referenced
this pull request
Nov 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mapuri - please review
This change moves the cluster wide resource allocation to a logically centralized entity. Doing at a logically central place allows for redundancy, avoids contention, and improves scale.