Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a bug on checks file. #17

Closed
wants to merge 1 commit into from
Closed

Fixed a bug on checks file. #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
# Folders
_obj
_test
.idea/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just for my understanding, how is this directory used? Is it IDE specific?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is the IntelliJ IDEA


# Architecture specific extensions/prefixes
*.[568vq]
Expand Down
2 changes: 1 addition & 1 deletion scripts/checks
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
echo "Checking Go version..."
ver=$(go version | awk '{print $3}')
expVer="go1.4"
if [[ ${ver} != ${expVer} ]]; then
if [[ ${ver:0:${#expVer}} != ${expVer} ]]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this let a user with go ver 1.4.1 to build?

There is a potential issue with allowing that, which I remember I hit during initial development of introducing these build time checks. Since the object files of 1.4.1 are not compatible with 1.4 (which is the go version in our vagrant box), it breaks 'make unit-test' which we need to run in a vagrant sandbox. To keep the test time low we went with a pre-customized box and had this stricter check.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! exactly I'm encounter those problems right now
gstate/gstate.go:25: import /opt/golang/pkg/linux_amd64/github.com/jainvipin/bitset.a: object is [linux amd64 go1.4.2 X:precisestack] expected [linux amd64 go1.4 X:precisestack]

echo "Go version check failed. Expected ${expVer} but found ${ver}"
exit 1
fi
Expand Down