Skip to content

Vagrantfile: added ability to install Docker EE (specified version) on centos #1099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 11, 2017

Conversation

dseevr
Copy link
Contributor

@dseevr dseevr commented Dec 6, 2017

envvar name is copied from https://docs.docker.com/engine/installation/linux/docker-ee/centos/

driveby: fixed a bug where node_os was an empty string instead of the default value because ENV["CONTIV_NODE_OS"] was being set to an empty string in the make target

Signed-off-by: Bill Robinson [email protected]

@dseevr dseevr force-pushed the install_docker_ee branch from 5af344b to e0cc3e1 Compare December 7, 2017 18:03
@unclejack
Copy link
Contributor

@dseevr: Can you provide some steps to know how to test this, please?

@dseevr
Copy link
Contributor Author

dseevr commented Dec 7, 2017

CONTIV_DOCKER_VERSION=17.06.2.ee.6-3.el7.centos.x86_64 DOCKERURL=<store_url> CONTIV_NODES=1 CONTIV_V2PLUGIN_NAME=contiv/v2plugin:1.1.7 make stop demo-v2plugin

replace DOCKERURL with your store URL :-)

@dseevr dseevr force-pushed the install_docker_ee branch 2 times, most recently from 6c04491 to 8633239 Compare December 7, 2017 20:29
@dseevr dseevr force-pushed the install_docker_ee branch from 8633239 to 4360283 Compare December 7, 2017 20:30
@dseevr dseevr changed the title Vagrantfile: added ability to install Docker EE (latest or specific version) on centos Vagrantfile: added ability to install Docker EE (specified version) on centos Dec 7, 2017
@dseevr
Copy link
Contributor Author

dseevr commented Dec 7, 2017

build pr

@unclejack
Copy link
Contributor

build PR

@dseevr
Copy link
Contributor Author

dseevr commented Dec 8, 2017

build pr

Copy link
Contributor

@unclejack unclejack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dseevr dseevr merged commit 503ac90 into contiv:master Dec 11, 2017
@dseevr dseevr deleted the install_docker_ee branch December 11, 2017 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants