Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

contiv k8s container now tagged with git version #1082

Merged
merged 2 commits into from
Nov 30, 2017
Merged

contiv k8s container now tagged with git version #1082

merged 2 commits into from
Nov 30, 2017

Conversation

chrisplo
Copy link
Contributor

the container build can leverage other new tasks to simplify the build
script considerably

drive-by: found the release notes for the container release was wrong

Signed-off-by: Chris Plock [email protected]

@chrisplo
contiv k8s container now tagged with git version
df18ce1 
the container build can leverage other new tasks to simplify the build
script considerably

drive-by: found the release notes for the container release was wrong

Signed-off-by: Chris Plock <[email protected]>
@chrisplo
Copy link
Contributor Author

build PR

@dseevr
Copy link
Contributor

dseevr commented Nov 27, 2017

build pr

@dseevr dseevr requested a review from unclejack November 28, 2017 08:38
@unclejack
Copy link
Contributor

make host-build-docker-image is failing for me with this branch:

Successfully built 0594eb131267
Successfully tagged netplugin-build:1.1.0-rc.1-400-ga0a08e2
docker rm netplugin-build 2>/dev/null || :
c_id=$(docker create --name netplugin-build netplugin-build:1.1.0-rc.1-400-ga0a08e2) && \
for f in netplugin netmaster netctl contivk8s netcontiv; do \
        docker cp ${c_id}:/go/bin/$f bin/$f; done && \
docker rm ${c_id}
bf3638a1e74e0d196b4f2274f863eac1aeeb179d2990107d58c7c08d0db5a62c
tar: scripts/netcontain/bin: Cannot open: No such file or directory
tar: Error is not recoverable: exiting now
Makefile:257: recipe for target 'host-build-docker-image' failed
make: *** [host-build-docker-image] Error 2

@unclejack
Copy link
Contributor

build PR

@chrisplo
Copy link
Contributor Author

chrisplo commented Nov 29, 2017 •
edited
Loading

@unclejack I'm puzzled, line 257 is nowhere near the target you are running:
https://github.com/chrisplo/netplugin/blob/master/Makefile#L257
I deleted the binaries in bin and in scripts/netcontain/bin and reran without an issue
Repeated that after a merge with master.

@chrisplo
Copy link
Contributor Author

build PR

unclejack
unclejack reviewed Nov 29, 2017
View reviewed changes
scripts/netContain/build_image.sh Outdated
fi
# it's expected that makefile targets compile-with-docker and
# binaries-from-container have already been run
tar c -C bin $NETPLUGIN_BINARIES | tar x -C scripts/netcontain/bin
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be netContain.

@unclejack
Copy link
Contributor

build PR

unclejack
unclejack approved these changes Nov 30, 2017
View reviewed changes
Copy link
Contributor

@unclejack unclejack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@unclejack unclejack merged commit 0b11750 into contiv:master Nov 30, 2017
@chrisplo chrisplo deleted the branch_build_k8s branch November 30, 2017 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dseevr dseevr dseevr approved these changes

@unclejack unclejack unclejack approved these changes

Assignees
No one assigned
Labels
squash when merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chrisplo @dseevr @unclejack