Ensure global config is valid before creating network #1070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
build PR |
chrisplo
approved these changes
Nov 16, 2017
|
build PR |
2 similar comments
|
build PR |
|
build PR |
chrisplo
approved these changes
Nov 16, 2017
|
build PR |
1 similar comment
|
build PR |
rchirakk
reviewed
Nov 17, 2017
netmaster/objApi/apiController.go
Outdated
|
|
||
| func validateGlobalConfig(netmode string) error { | ||
| globalConfig := contivModel.FindGlobal("global") | ||
| if globalConfig.FwdMode == "" { |
There was a problem hiding this comment.
globalConfig != nil check ?
There was a problem hiding this comment.
i don't think globalConfig would be nil once the netmaster started, although i can add the check
When global config (espeically fwd mode) is not set, we shouldn't allow creating network. The network created at that moment is may not having enough data to proceed. Also ensure global settings are set before any network creating in objapi_test Signed-off-by: Wei Tie <[email protected]>
|
squashed |
|
build PR |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When global config (espeically fwd mode) is not set, we shouldn't
allow creating network. The network created at that moment is may
not having enough data to proceed.
Signed-off-by: Wei Tie [email protected]