v2plugin set forward mode when netmaster up #1058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docker expects the netplugin socket to be available within 10 seconds before it fails enabling (or installing) the v2plugin. Due to contiv#1043, netplugin is blocking waiting for the forward mode to be set, which is done by netctl calling netmaster, but netmaster is not started until the plugin is activating. Instead of backgrounding the plugin install/enabling then letting ansible set the forward mode, do it in the plugin script to avoid ansible's unpredictable round trip delays. Signed-off-by: Chris Plock <[email protected]>
tiewei
reviewed
Nov 11, 2017
install/v2plugin/startcontiv.sh
Outdated
| exit 1 | ||
| fi | ||
| sleep 1 | ||
| echo "Netmaster ready for connections, setting forward mode to $fwd_mode" |
There was a problem hiding this comment.
a nit, could we exit 1 when $fwd_mode not set ?
rchirakk
suggested changes
Nov 13, 2017
| }, | ||
| { | ||
| "Description": "Forwarding mode for netplugin", | ||
| "Name": "fwd_mode", |
There was a problem hiding this comment.
There was a problem hiding this comment.
check if you need to configure Fabric mode(ACI/default) also here
There was a problem hiding this comment.
it's fine for now about fabric mode
tiewei
reviewed
Nov 13, 2017
| fi | ||
| sleep 1 | ||
| echo "Netmaster ready for connections, setting forward mode to $fwd_mode" | ||
| /netctl --netmaster http://$control_url global set --fwd-mode "$fwd_mode" |
There was a problem hiding this comment.
i think we need to check if fwd mode has been set or if it's allowed to update, or we can check the return code, if it's 5xx then retry, if it's 2xx or 4xx, it might be good to move on
There was a problem hiding this comment.
i did testing, the request is idempotent , as long as it's not changing the mode when there's network, we should be good
|
build PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker expects the netplugin socket to be available within 10 seconds
before it fails enabling (or installing) the v2plugin.
Due to #1043, netplugin is blocking waiting for the forward mode to be
set, which is done by netctl calling netmaster, but netmaster is not
started until the plugin is activating.
Instead of backgrounding the plugin install/enabling then letting
ansible set the forward mode, do it in the plugin script to avoid
ansible's unpredictable round trip delays.
Adds a plugin setting for the forward mode
Drive-by: Logging to stdout and stderr for some commands were not
making it to the logfile, this change redirects all to the logfile
Signed-off-by: Chris Plock [email protected]