Remove test/systemtests/cfg.json so that it will be ignored #1038
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To run the Contiv k8s system tests, before running
make k8s-test
, we must first runscripts/python/createcfg.py
(https://github.com/contiv/netplugin/blob/master/Makefile#L172).scripts/python/createcfg.py
createstest/systemtests/cfg.json
in https://github.com/contiv/netplugin/blob/master/scripts/python/createcfg.py#L77-L80.But, since
test/systemtests/cfg.json
already exists in https://github.com/contiv/netplugin/blob/master/test/systemtests/cfg.json,. gitignore
does not ignore it in https://github.com/contiv/netplugin/blob/master/.gitignore#L63 as git does not ignore a file already present in the repo. Due to this issue, contributors have unnecessarily committedtest/systemtests/cfg.json
into the netplugin repo by mistake (https://github.com/contiv/netplugin/commits/master/test/systemtests/cfg.json).Hence, removing
test/systemtests/cfg.json
so that it will be ignored by. gitignore
.Signed-off-by: Vikram Hosakote [email protected]