Skip to content

Remove test/systemtests/cfg.json so that it will be ignored #1038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2017
Merged

Remove test/systemtests/cfg.json so that it will be ignored #1038

merged 1 commit into from
Oct 30, 2017

Conversation

vhosakot
Copy link
Member

@vhosakot vhosakot commented Oct 30, 2017

To run the Contiv k8s system tests, before running make k8s-test, we must first run scripts/python/createcfg.py (https://github.com/contiv/netplugin/blob/master/Makefile#L172). scripts/python/createcfg.py creates test/systemtests/cfg.json in https://github.com/contiv/netplugin/blob/master/scripts/python/createcfg.py#L77-L80.

But, since test/systemtests/cfg.json already exists in https://github.com/contiv/netplugin/blob/master/test/systemtests/cfg.json, . gitignore does not ignore it in https://github.com/contiv/netplugin/blob/master/.gitignore#L63 as git does not ignore a file already present in the repo. Due to this issue, contributors have unnecessarily committed test/systemtests/cfg.json into the netplugin repo by mistake (https://github.com/contiv/netplugin/commits/master/test/systemtests/cfg.json).

Hence, removing test/systemtests/cfg.json so that it will be ignored by . gitignore.

Signed-off-by: Vikram Hosakote [email protected]

@vhosakot vhosakot changed the title Remove test/systemtests/cfg.json so that it will be ignored by .gitig… Remove test/systemtests/cfg.json so that it will be ignored Oct 30, 2017
@vhosakot
Copy link
Member Author

build PR

Copy link
Contributor

@unclejack unclejack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@unclejack unclejack merged commit 453e274 into contiv:master Oct 30, 2017
@vhosakot
Copy link
Member Author

@dseevr @rchirakk @gaurav-dalvi - this got merged before I corrected the reference to netplugin/systemtests/cfg.json in the documentation in https://github.com/contiv/netplugin/blob/master/test/systemtests/How-to-Run.md. I'll submit a separate PR to correct the documentation and also add cfg.json.example as a sample for the user.

@vhosakot vhosakot deleted the remove_systemtests_cfg.json branch October 31, 2017 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants