Ensure ovs logging directory created before start service #1028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisplo
reviewed
Oct 21, 2017
| @@ -27,6 +28,8 @@ ovsdb-server --remote=punix:/var/run/openvswitch/db.sock --remote=db:Open_vSwitc | |||
| echo "Starting ovs-vswitchd" | |||
| ovs-vswitchd -v --pidfile --detach --log-file=/var/contiv/log/ovs-vswitchd.log -vconsole:err -vsyslog:info -vfile:info & | |||
|
|
|||
| sleep 2 | |||
There was a problem hiding this comment.
Is there a simple ovs-vsctl command we can run here to poll instead of sleeping?
gkvijay
approved these changes
Oct 21, 2017
dseevr
reviewed
Oct 23, 2017
| @@ -27,6 +28,11 @@ ovsdb-server --remote=punix:/var/run/openvswitch/db.sock --remote=db:Open_vSwitc | |||
| echo "Starting ovs-vswitchd" | |||
| ovs-vswitchd -v --pidfile --detach --log-file=/var/contiv/log/ovs-vswitchd.log -vconsole:err -vsyslog:info -vfile:info & | |||
|
|
|||
| while [[ $(ovsdb-client list-dbs | grep -c Open_vSwitch) -eq 0 ]] ; do | |||
| echo "Wait for ovsdb started" | |||
There was a problem hiding this comment.
Can we change this to "Waiting for ovsdb to start"?
Also, should we fail after N attempts? We do that in other places where we poll for readiness
Without this patch, when a node first time start netplugin, and if there wasn't netmaster started ever on the node, the ovs logging directory will not exist and no logging will be able to be found. This patch makes sure the ovs logging directory created before service starts. Also added a wait step before ovsdb ready, and logging level. changes the indentation to 4 spaces and make codes more readable Signed-off-by: Wei Tie <[email protected]>
|
build pr |
chrisplo
approved these changes
Oct 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this patch, when a node first time start netplugin, and if
there wasn't netmaster started ever on the node, the ovs logging
directory will not exist and no logging will be able to be found.
This patch makes sure the ovs logging directory created before
service starts.
Signed-off-by: Wei Tie [email protected]