Removed GOPATH check

[vhosakot]

Not all Makefile targets need GOPATH to be set. Makefile targets like demo and demo-v2plugin do not need GOPATH to be set in order to sync the directory src/github.com/contiv/netplugin on the laptop with /opt/gopath inside the vagrant VM (https://github.com/contiv/netplugin/blob/master/Vagrantfile#L370). Targets like tar and compile-with-docker also do not need GOPATH.

Hence, this PR removes the check for GOPATH in the Makefile and adds documentation in README.md for the user to set GOPATH when using Makefile targets like k8s-test, system-test, clean and compile that do need GOPATH to be set (https://github.com/contiv/netplugin/blob/master/Makefile#L99).

Tested on Mac laptop.

Signed-off-by: Vikram Hosakote [email protected]

[vhosakot]

build PR

[davidlapsleyio]

Thanks for doing this @vhosakot. I did things slightly differently and it seemed to work:

• cd ~/repos
• git clone [email protected]:contiv/netgplugin
• cd netplugin
• export GOPATH=pwd
• make demo

That seemed to work.

Actually, this does not work. Disregard :)

[rchirakk]

I don't think you need this change, it is covered by the first line.

[vhosakot]

@rchirakk The first line is not clear IMO. It does not clearly say "you MUST set GOPATH for certain targets". Hence, @delapsley and I both saw issues without GOPATH as there is no check for empty GOPATH in Makefile. Since there is no check for empty GOPATH, I added this clear note for the user.

[vhosakot]

@rchirakk I removed the note in the documentation. FYI, when GOPATH is not set, there is no check in the code now and no docs too about it and the build does not fail fast. I still think the documentation is unclear 😄 because of which @delapsley and I both saw the same issue when GOPATH is not set.

[vhosakot]

build PR

[rchirakk]

LGTM