Skip to content

make demo is failing with today's (22nd August) netplugin code #537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gaurav-dalvi opened this issue Aug 22, 2016 · 9 comments
Closed

make demo is failing with today's (22nd August) netplugin code #537

gaurav-dalvi opened this issue Aug 22, 2016 · 9 comments

Comments

@gaurav-dalvi
Copy link
Contributor

Error :

Simple error. But still wondering how come our sanity did not catch this.

# github.com/contiv/netplugin/netctl
netctl/netctl.go:622: undefined: argCheck
@gaurav-dalvi
Copy link
Contributor Author

two PRs merging order caused this issue.

@gaurav-dalvi
Copy link
Contributor Author

PR : #528

and

PR : #527

@jainvipin
Copy link

@gaurav-dalvi - per @shaleman's comment argcheck in #527 should have been removed, wonder why it didn't

@gaurav-dalvi
Copy link
Contributor Author

@jainvipin :
after this my PR was merged and I had that check and thats why its failing.

@rchirakk
Copy link
Contributor

I have added a fix in this PR as my commit build was failing,
#536

@gaurav-dalvi
Copy link
Contributor Author

@rchirakk : Please dont do that.
I am thinking of omitting this PR #527 from our main repo. It broke some other functionality as well.

Waiting for @shaleman to comment on this one.

gaurav-dalvi added a commit to gaurav-dalvi/netplugin that referenced this issue Aug 22, 2016
@gaurav-dalvi
Solving Issue contiv#537, contiv#525 contiv#532
5d8e58f
@gaurav-dalvi gaurav-dalvi mentioned this issue Aug 22, 2016
Merged
@gaurav-dalvi
Copy link
Contributor Author

PR - #539 is raised for this.

gaurav-dalvi added a commit to gaurav-dalvi/netplugin that referenced this issue Aug 23, 2016
@gaurav-dalvi
Solving Issue contiv#537, contiv#525 contiv#532
8cbcd4e
jainvipin pushed a commit that referenced this issue Aug 23, 2016
Merge pull request #539 from gaurav-dalvi/fix-22ndAug
813f1dd 
Solving Issue #537, #525 #532
@gaurav-dalvi
Copy link
Contributor Author

Fixed via this PR : #539

@gaurav-dalvi
Copy link
Contributor Author

Closing it !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gaurav-dalvi @jainvipin @rchirakk