Skip to content

fix: ollama tool use #5596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2025
Merged

fix: ollama tool use #5596

merged 1 commit into from
May 9, 2025

Conversation

tomasz-stefaniak
Copy link
Collaborator

@tomasz-stefaniak tomasz-stefaniak commented May 9, 2025

Description

Add missing ollama tool call ids.

Checklist

  • I've read the contributing guide
  • The relevant docs, if any, have been updated or created
  • [] The relevant tests, if any, have been updated or created

Screenshots

[ For visual changes, include screenshots. Screen recordings are particularly helpful, and appreciated! ]

Testing instructions

[ For new or modified features, provide step-by-step testing instructions to validate the intended behavior of the change, including any relevant tests to run. ]


Summary by mrge

Added missing unique IDs to Ollama tool calls to ensure each tool call is properly identified.

@tomasz-stefaniak tomasz-stefaniak requested a review from a team as a code owner May 9, 2025 20:40
@tomasz-stefaniak tomasz-stefaniak requested review from RomneyDa and removed request for a team May 9, 2025 20:40
Copy link

netlify bot commented May 9, 2025

Deploy Preview for continuedev canceled.

Name Link
🔨 Latest commit 82ac684
🔍 Latest deploy log https://app.netlify.com/sites/continuedev/deploys/681e683403e5790008946dfa

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label May 9, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 9, 2025
@tomasz-stefaniak tomasz-stefaniak merged commit 4b33db7 into main May 9, 2025
36 checks passed
@tomasz-stefaniak tomasz-stefaniak deleted the tomasz/fix-ollama-tool-use branch May 9, 2025 20:59
@github-project-automation github-project-automation bot moved this from Todo to Done in Issues and PRs May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants