-
Notifications
You must be signed in to change notification settings - Fork 2.8k
fix(mode-switch)-tools-calls-broken #5528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(mode-switch)-tools-calls-broken #5528
Conversation
✅ Deploy Preview for continuedev canceled.
|
@Patrick-Erichsen @tomasz-stefaniak FYI based on issues I am attempting to resolve. Note this is the current top complaint from my team that uses continue. |
Hey @chezsmithy , thanks for the PR! Chatted this over with @sestinj this morning - we both agreed that the chat/agent system messages are a great addition, but the tool calling in Chat mode we'd like to avoid. I can see the value in having the subset of tools available in Chat, but the problem is that exposing these tools makes the models way too eager to use tools instead of just answering questions directly, which is the intended behavior for Chat. E.g. I tried to ask a simple question with 3.7 Sonnet and instead it searched my codebase, couldn't find the answer, then searched the web, etc With that being said, a few points of feedback on the system message updates:
|
@Patrick-Erichsen @tomasz-stefaniak ok, I've made the suggested changes and cleaned up. I've got a problem with a failing GUI test. Now that tool calls are explicitly blocked in chat mode I need a way to add the Mode selector to the GUI test. I tried to do that, but can't quite seem to get the syntax right. Could you please review and suggest how I might resolve the GUI test issue? Thx! |
@chezsmithy pushed up a fix that will hopefully resolve it, your syntax was correct, I think we just needed to hardcode the We chatted more as a team yesterday on the ability to have tool calling outside of Agent mode. I think it's likely we'll move in that direction in the near term, but we might approach it differently than just an additional mode. In general though I think we're all aligned that there's value in a "safe" mode to explore the codebase, plan, pull in context from MCPs, etc, that doesn't allow for code edits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Description
Resolves: #5510
Checklist
Screenshots
[ For visual changes, include screenshots. Screen recordings are particularly helpful, and appreciated! ]
Testing instructions