Skip to content

Fixing issue #4239 (FTS not working for multiple word query) #5392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2025

Conversation

eramitmittal
Copy link
Contributor

Fixing issue #4239 by escaping the trigrams instead of escaping the OR joined trigrams.

Currently OR joined trigrams are escaped, leading to OR getting treated literally and hence FTS is not matching any chunks.

@eramitmittal eramitmittal requested a review from a team as a code owner April 28, 2025 07:42
@eramitmittal eramitmittal requested review from sestinj and removed request for a team April 28, 2025 07:42
Copy link

netlify bot commented Apr 28, 2025

Deploy Preview for continuedev ready!

Name Link
🔨 Latest commit fa7c8cc
🔍 Latest deploy log https://app.netlify.com/sites/continuedev/deploys/680f3179eca38b00088bfd3f
😎 Deploy Preview https://deploy-preview-5392--continuedev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@eramitmittal eramitmittal changed the title Fixing issue #4239 Fixing issue #4239 (FTS not working for multiple word query) Apr 28, 2025
@sestinj
Copy link
Contributor

sestinj commented Apr 29, 2025

Good catch @eramitmittal ! Appreciate the fix

@sestinj sestinj merged commit 5d5cf02 into continuedev:main Apr 29, 2025
33 checks passed
@eramitmittal eramitmittal deleted the Issue#4239 branch April 30, 2025 11:12
@sestinj
Copy link
Contributor

sestinj commented May 15, 2025

Hi @eramitmittal, yesterday we shared some updates with our contributors about how we're aiming to improve the contribution process. Part of this included the addition of a Contributor License Agreement (CLA) to protect both contributors and the project. We're reaching out to ask that previous contributors sign it.

Could you please take a moment to sign, or if you have any questions send me a message? (either here or [email protected] would work)

To do so, you just need to post a comment below with the following text:

I have read the CLA Document and I hereby sign the CLA

❤️ Thank you for the work you've done on Continue, and let me know if you have any suggestions on how we can make the project even better!

Copy link

github-actions bot commented May 15, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@eramitmittal
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants